Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/plex: allow access to hardware acceleration libraries #54279

Merged
merged 1 commit into from Jan 23, 2019
Merged

nixos/plex: allow access to hardware acceleration libraries #54279

merged 1 commit into from Jan 23, 2019

Conversation

bachp
Copy link
Member

@bachp bachp commented Jan 18, 2019

Motivation for this change

CUDA and OpenCL libraries are located in /run/opengl-driver/lib and Plex
can make use of them if available.

I added this because Plex was complaining that it could not find libcuda when enabling HW transcoding. After extending the LD_LIBRARY_PATH CUDA was detected by Plex. However it turns out my HW is to old to support any HW transcoding so I'm unable to really test it. But it should not hurt to have it there.

Maybe somebody with more recent hardware can verify it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bachp bachp requested a review from infinisil as a code owner January 18, 2019 16:59
@ghost
Copy link

ghost commented Jan 22, 2019

I can test it out on my hardware, but I'm not sure how to do that. Can you provide an example test case?

@infinisil
Copy link
Member

NixOS indeed has /run/opengl-driver/lib on its LD_LIBRARY_PATH, which is what makes opengl tick, so it also makes sense to have it for a service that requires it. I'll merge this now, should work just fine :)

@infinisil
Copy link
Member

Oh one thing @bachp, please format your commit message according to the guidelines linked in the issue template, this means it should look like "nixos/plex: allow .."

@bachp
nixos/plex: allow access to hardware acceleration libraries
8347722 
CUDA and OpenCL libraries are located in /run/opengldriver/lib and Plex
can make use of them if available.
@bachp bachp changed the title plex service: allow access to hardware acceleration libraries nixos/plex: allow access to hardware acceleration libraries Jan 23, 2019
@bachp
Copy link
Member Author

bachp commented Jan 23, 2019

@infinisil commit message updated according latest contribution guide.

@infinisil infinisil merged commit 73764a2 into NixOS:master Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bachp @infinisil @GrahamcOfBorg