Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gnome fixes (gnome-documents and eog) #54268

Merged
merged 2 commits into from Jan 18, 2019
Merged

Gnome fixes (gnome-documents and eog) #54268

merged 2 commits into from Jan 18, 2019

Conversation

hedning
Copy link
Contributor

@hedning hedning commented Jan 18, 2019

Motivation for this change

Fixes gnome-documents so it can actually show documents.

Fixes eog thumbnailing.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added 6.topic: GNOME GNOME desktop environment and its underlying platform 8.has: documentation labels Jan 18, 2019
@jtojnar
Copy link
Contributor

jtojnar commented Jan 18, 2019

Relevant, GNOME Documents might be dropped https://mail.gnome.org/archives/desktop-devel-list/2019-January/msg00024.html

@hedning
Copy link
Contributor Author

hedning commented Jan 18, 2019

Right, lets consider removing it in 3.32 then (at least from the default).

@hedning hedning merged commit 4fe0bd0 into NixOS:master Jan 18, 2019
@hedning hedning deleted the gnome-fixes branch October 15, 2019 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 8.has: documentation 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hedning @jtojnar @GrahamcOfBorg