Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lua: autogenerate some more packages #55680

Merged
merged 5 commits into from Feb 13, 2019
Merged

Conversation

teto
Copy link
Member

@teto teto commented Feb 13, 2019

Motivation for this change

autogenerate some more packages

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@teto
Copy link
Member Author

teto commented Feb 13, 2019

@7c6f434c feel free to launch the darwin build.
There are still lua-zlib/lua-cjson/luaexpat (from #55263) that I would like to generate but there might be problems with these ones so I might do them in smaller chunks.

"date": "2013-02-18T16:36:42+01:00",
"sha256": "0lsc556hlkddjbmcdbg7wc2g55bfy743p8ywdzl8x7kk847r043q",
"fetchSubmodules": true
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if there is an easy way to improve generated formatting here — this point is a large «wait what» when reading.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't want to write my own tool so I use the output of nix-prefetch-url/git. This is my cry out for help:
https://discourse.nixos.org/t/generate-nix-code-to-fetch-package-from-url/1941

Anyway as this is generated, it's easy to fix afterwards, luarocks-nix is a huge mess now I would need to remove all the comments first so that others can fix it. I would also like to have everything sorted alphabetically as well.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can remove it from the list if it's a problem

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, not an immediate problem, just a thing to keep in mind.

I wonder if this file would get better or worse from just feeding through indent.

@7c6f434c
Copy link
Member

@GrahamcOfBorg build luaPackages.luaevent luaPackages.luacheck luaPackages.luabitop luaPackages.lpty luaPackages.lua-iconv

@teto
Copy link
Member Author

teto commented Feb 13, 2019

seems like it timed out.

@7c6f434c
Copy link
Member

OK, Git on macOS is not my hill to die on, the non-git-source packages seem to work.

@7c6f434c 7c6f434c merged commit 96479af into NixOS:master Feb 13, 2019
@teto teto deleted the lua_whitelist branch February 13, 2019 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants