Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: c0cfe9bf500f
Choose a base ref
...
head repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 6dc46f3f0150
Choose a head ref
  • 2 commits
  • 1 file changed
  • 1 contributor

Commits on Feb 11, 2019

  1. zoom-us: don't set dontPatchELF 

    otherwise, autopatchelfHook seems to ignore patchelfing the zoom binary
properly, causing it to fail to start:

result/bin/zoom-us: line 4: /nix/store/7jfk4jggclvbwqxm9x4b4d57rr1mjh9q-zoom-us-2.7.162522.0121/share/zoom-us/zoom: No such file or directory
    @flokli
    flokli committed Feb 11, 2019
    Copy the full SHA
    109966d View commit details

Commits on Feb 12, 2019

  1. Merge pull request #55566 from flokli/zoom-us-fix 

    zoom-us: don't set dontPatchELF
    @flokli
    flokli authored Feb 12, 2019

    Verified

    This commit was signed with the committer’s verified signature.
    caendesilva Caen De Silva
    GPG key ID: F1E5FB7C768BCE52
    Verified
    Learn about vigilant mode
    Copy the full SHA
    6dc46f3 View commit details
Showing with 0 additions and 3 deletions.
  1. +0 −3 pkgs/applications/networking/instant-messengers/zoom-us/default.nix
3 changes: 0 additions & 3 deletions pkgs/applications/networking/instant-messengers/zoom-us/default.nix
View file
Original file line number Diff line number Diff line change
@@ -41,9 +41,6 @@ in stdenv.mkDerivation {

runtimeDependencies = optional pulseaudioSupport libpulseaudio;

# Don't remove runtimeDependencies from RPATH via patchelf --shrink-rpath
dontPatchELF = true;

installPhase =
let
files = concatStringsSep " " [