Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 148e5b41d6: Uninitialized variable usage. #7216

Merged
merged 1 commit into from Feb 10, 2019
Merged

Fix 148e5b41d6: Uninitialized variable usage. #7216

merged 1 commit into from Feb 10, 2019

Conversation

PeterN
Copy link
Member

@PeterN PeterN commented Feb 10, 2019

Fixed by moving the call to invalidate the vehicle details window into the if () condition as well.

glx22
glx22 approved these changes Feb 10, 2019
View reviewed changes
Copy link
Contributor

@glx22 glx22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course if init is hidden in math it was easy to miss it

@PeterN PeterN merged commit 22f33fd into OpenTTD:master Feb 10, 2019
@PeterN PeterN deleted the fix-148e5b41d6 branch February 10, 2019 21:07
nielsmh pushed a commit to nielsmh/OpenTTD that referenced this pull request Mar 11, 2019
@PeterN @nielsmh
Fix 148e5b4: Uninitialized variable usage. (OpenTTD#7216)
d446138
douiwby pushed a commit to douiwby/OpenTTD that referenced this pull request Apr 16, 2020
@PeterN @douiwby
Fix 148e5b4: Uninitialized variable usage. (OpenTTD#7216)
55eae93
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glx22 glx22 glx22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@PeterN @glx22