New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cdimgtools,perlPackages.DataHexdumper: init at 0.3, init at 3.001 #55615
Conversation
@GrahamcOfBorg eval |
Is this ready to be merged? It is now compatible with latest |
Also please rebase instead of merging, and squash/fixup any extra commits or cleanup the git history. |
@worldofpeace Integrated your suggestions and squashed the commits. Thanks for the review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, though I haven't tested this, so I need to verify its function through other means.
@hhm0 Have you tested that all the binaries produced worked for you?
@worldofpeace Yup |
Great, merging in that case 👍 |
@worldofpeace Thanks for your help reviewing and suggesting! :-) |
Motivation for this change
Adds the
CD|imgtools
package, which is useful for certain operations on CD images.Also adds its dependencies which were not already present.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)