Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnome-chess: 3.30.0 -> 3.30.1 #55608

Merged
merged 1 commit into from Feb 17, 2019
Merged

gnome-chess: 3.30.0 -> 3.30.1 #55608

merged 1 commit into from Feb 17, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Feb 12, 2019

Motivation for this change

After fixing common-update-scripts
found this could be updated.
(and related gnome-y updates submitted as sibling PR's)
No other reason O:).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Feb 12, 2019
worldofpeace
worldofpeace approved these changes Feb 12, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and executes fine, news looks minimal.

However I don't think we have a game engine configured for this.
So the default function isn't complete.

Looks like the default engine fedora uses is gnuchess so maybe we should add an option to include it in path?

@worldofpeace worldofpeace merged commit e6b76ad into NixOS:master Feb 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

@jtojnar jtojnar Awaiting requested review from jtojnar

@hedning hedning Awaiting requested review from hedning

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @worldofpeace @GrahamcOfBorg