Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flannel: 0.6.2 -> 0.11.0 #55559

Merged
merged 2 commits into from Feb 11, 2019
Merged

flannel: 0.6.2 -> 0.11.0 #55559

merged 2 commits into from Feb 11, 2019

Conversation

johanot
Copy link
Contributor

@johanot johanot commented Feb 11, 2019

Motivation for this change

The Flannel package current version (0.6.2) is from 2016. Since it is used as default CNI implementation in Kubernetes, it seems a bit scary to use such an old version.

Added myself as maintainer on the package.

Ran both the kubernetes RBAC and DNS test cases, and they both work fine with flannel 0.11.0.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli
Copy link
Contributor

flokli commented Feb 11, 2019

@GrahamcOfBorg test kubernetes flannel

@flokli flokli merged commit 1c218a2 into NixOS:master Feb 11, 2019
@flokli
Copy link
Contributor

flokli commented Feb 11, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants