[LayoutNG] Add percentage_resolution_block_size into the min/max pass. #15322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Feb 11, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1456203
branch
2 times, most recently
from
320a0dd
to
35ef98b
Compare
This was surprising to me! But the min/max sizes depend on the percentage resolution block-size, as replaced elements reflect this size into their width. This was working previously as the replaced element was manually computing the heights, but this adds it into the pass explicitly. This fixes it for absolute positioned objects which use the current final height as the input to this function. Eventually we'll want to cache based off this, and record if there is a replaced element with percentage block-size in the calculation chain. Bug: 635619 Change-Id: I6db9a90007b6c7d70f51d5ae1209ffba8a629e03 Reviewed-on: https://chromium-review.googlesource.com/c/1456203 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Aleks Totic <atotic@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#631236}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1456203
branch
from
35ef98b
to
6720d76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was surprising to me! But the min/max sizes depend on the
percentage resolution block-size, as replaced elements reflect this
size into their width.
This was working previously as the replaced element was manually
computing the heights, but this adds it into the pass explicitly.
This fixes it for absolute positioned objects which use the current
final height as the input to this function.
Eventually we'll want to cache based off this, and record if there is
a replaced element with percentage block-size in the calculation chain.
Bug: 635619
Change-Id: I6db9a90007b6c7d70f51d5ae1209ffba8a629e03
Reviewed-on: https://chromium-review.googlesource.com/c/1456203
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631236}