Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codechange-Commits from #6599 #7215

Closed
wants to merge 6 commits into from
Closed

Codechange-Commits from #6599 #7215

wants to merge 6 commits into from

Conversation

Eddi-z
Copy link
Contributor

@Eddi-z Eddi-z commented Feb 10, 2019

As only the first 2 changes were considered for #7049, here is the rest

@PeterN
Copy link
Member

PeterN commented Feb 10, 2019

What is this PR about?

@Eddi-z
Copy link
Contributor Author

Eddi-z commented Feb 10, 2019

Mainly to have these commits not-lost in case someone wants to review them?

@PeterN
Copy link
Member

PeterN commented Feb 10, 2019

Sorry but PRs should be well formed with intentions, goals and reasons, not just a collection of random commits just to keep them around.

@Eddi-z
Copy link
Contributor Author

Eddi-z commented Feb 10, 2019

I don't know what you want to hear. the commits have a description, and a tiny bit of details are in #6599, the original ticket. i was asked to turn the patches into a PR, so here you are. Do what you want with it.

@PeterN
Copy link
Member

PeterN commented Feb 10, 2019

I'm closing this now as the remaining patches do not form a coherent sequence. We can still pick bits and pieces if we wish.

@PeterN PeterN closed this Feb 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants