Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mailman-rss: init at 0.2.4 #55534

Merged
merged 1 commit into from Feb 11, 2019
Merged

mailman-rss: init at 0.2.4 #55534

merged 1 commit into from Feb 11, 2019

Conversation

samueldr
Copy link
Member

Motivation for this change

Might be useful to a couple maintainers here; to keep track of mailing lists in an RSS reader instead of dealing with e-mails.

First python ecosystem contribution, don't hold back with the nitpicks.

Verified it built and worked with both python 2 and python 3.

Things done
  • ✔️ Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • ✔️ NixOS
  • ✔️ Tested execution of all binary files (usually in ./result/bin/)
  • ✔️ Assured whether relevant documentation is up to date
  • ✔️ Fits CONTRIBUTING.md.

@dotlambda
Copy link
Member

If I'm not mistaken, this is never imported as a Python library und should thus use buildPythonApplication and be moved to all-packages.nix.

@worldofpeace
Copy link
Contributor

Looks like we're on the same page @dotlambda #55534 (comment) 😄

@dotlambda dotlambda changed the title pythonPackages.mailman-rss: init at 0.2.4 mailman-rss: init at 0.2.4 Feb 11, 2019
@flokli flokli merged commit b5f3b7d into NixOS:master Feb 11, 2019
@samueldr samueldr deleted the mailman-rss/init branch February 12, 2019 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants