Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclosed URL At EOF #15369

Merged
merged 1 commit into from Feb 12, 2019
Merged

Unclosed URL At EOF #15369

merged 1 commit into from Feb 12, 2019

Conversation

tabatkins
Copy link
Contributor

Verifies that a url() (specifically, one that parses to a <url-token>) that's unclosed at EOF is still valid.

Also tests "empty" url(), because that was brought up as another source of divergence in the same issue. There's some disagreement on whether that's valid at all and how to represent it, so rather than take a stand, I just assert that it should parse the same as the closed version, whatever that is.

Tests w3c/csswg-drafts#3598

Verifies that a url() (specifically, one that parses to a `<url-token>`) that's unclosed at EOF is still valid.

Also tests "empty" url(), because that was brought up as another source of divergence in the same issue. There's some disagreement on whether that's valid at all and how to represent it, so rather than take a stand, I just assert that it should parse the same as the closed version, whatever that is.

Tests <w3c/csswg-drafts#3598>
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tabatkins tabatkins merged commit 8dbed22 into master Feb 12, 2019
@tabatkins tabatkins deleted the tabatkins-patch-1 branch February 15, 2019 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants