[Animation Worklet] Clean up animator registration logic for wpt test #15344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Feb 12, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1466145
branch
from
d4344d5
to
e90739c
Compare
Similar to [1], we should register the animator only once in the setup for test current-time.https.html. Given that DocumentTimeline does not always move forward, this test also replaces waitForNextFrame with waitForDocumentTimelineAdvance. [1] https://cs.chromium.org/chromium/src/third_party/blink/web_tests/external/wpt/animation-worklet/scroll-timeline-writing-modes.https.html Bug: 923881 Change-Id: Iabc6c7c1cea520e3dd81ed8a781cc072e2d8e20b Reviewed-on: https://chromium-review.googlesource.com/c/1466145 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#631287}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1466145
branch
from
e90739c
to
740d171
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to [1], we should register the animator only once in the setup
for test current-time.https.html.
Given that DocumentTimeline does not always move forward, this test
also replaces waitForNextFrame with waitForDocumentTimelineAdvance.
[1] https://cs.chromium.org/chromium/src/third_party/blink/web_tests/external/wpt/animation-worklet/scroll-timeline-writing-modes.https.html
Bug: 923881
Change-Id: Iabc6c7c1cea520e3dd81ed8a781cc072e2d8e20b
Reviewed-on: https://chromium-review.googlesource.com/c/1466145
Commit-Queue: Yi Gu <yigu@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631287}