Don't use mozdownload to download firefox #15329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgraham
force-pushed
the
no_mozdownload_firefox
branch
2 times, most recently
from
11c025a
to
71536c9
Compare
Instead use the same URL that's used by mozilla.org. This hopefully reduces the problem where mozdownload tries to download a file that doesn't exist yet. Note that we are still using mozdownload for geckodriver
jgraham
force-pushed
the
no_mozdownload_firefox
branch
from
71536c9
to
41220ac
Compare
|
Fixes #13274 |
Ms2ger
approved these changes
Feb 12, 2019
whimboo
reviewed
Feb 12, 2019
| product = { | ||
| "nightly": "firefox-nightly-latest-ssl", | ||
| "beta": "firefox-beta-latest-ssl", | ||
| "stable": "firefox-beta-latest-ssl" |
There was a problem hiding this comment.
@jgraham I think what you really want here for stable is https://download.mozilla.org/?product=firefox-latest-ssl&os=osx&lang=en-US. Otherwise you aren't using the release but beta version on stable.
| filename = urlparse.urlsplit(resp.url).path.rsplit("/", 1)[1] | ||
|
|
||
| if not filename: | ||
| filename = "firefox.tar.bz2" |
There was a problem hiding this comment.
So we don't run those tests on other platforms than Linux?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead use the same URL that's used by mozilla.org. This hopefully reduces the
problem where mozdownload tries to download a file that doesn't exist yet.
Note that we are still using mozdownload for geckodriver