Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] buildEnv: accept arbitrary arguments, pass to runCommand #55567

Closed
wants to merge 1 commit into from
Closed

[WIP] buildEnv: accept arbitrary arguments, pass to runCommand #55567

wants to merge 1 commit into from
+7 −8

Conversation

timor
Copy link
Member

@timor timor commented Feb 11, 2019

Motivation for this change

In contrast to other places in nixpkgs, buildEnv does not pass any unknown attributes to runCommand.

With the changes of this PR, the attributes, which give more fine-grained control over the
resulting derivation, don't have to be specified explicitly in buildEnv, but are passed to runCommand
as is.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@timor
buildEnv: accept arbitrary arguments, pass to runCommand
dbdcd9c 
This way, the attributes, which give more fine-grained control over the
resulting derivation don't have to be specified explicitly.
@ryantm ryantm added the 2.status: work-in-progress This PR isn't done label Feb 24, 2019
@lheckemann
Copy link
Member

What's your use for this?

@timor
Copy link
Member Author

timor commented Aug 4, 2019

Good question. Somewhere I copied a lot of code because of this, but I cannot find the specific case. I guess I'll reopen it if it comes up again...

cc @spacefrogg

@timor timor closed this Aug 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: work-in-progress This PR isn't done 10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@timor @lheckemann @ryantm @GrahamcOfBorg