Picture-in-Picture: remove/rename some methods in player/video element. #15345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Feb 12, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1409544
branch
3 times, most recently
from
bc18e7e
to
1acbadf
Compare
Mostly follow-ups from https://chromium-review.googlesource.com/c/chromium/src/+/1379049 Some methods became pointless, some had their meaning significantly changed. This CL also changes the timing of requestPictureInPicture() and exitPictureInPicture() in order to be sync until the call to the service. Bug: 919860, 930338 Change-Id: I437a060c2dd92021d514c4d6e2ffeb9f4642525b Reviewed-on: https://chromium-review.googlesource.com/c/1409544 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#631517}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1409544
branch
from
1acbadf
to
cca925a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly follow-ups from https://chromium-review.googlesource.com/c/chromium/src/+/1379049
Some methods became pointless, some had their meaning significantly
changed.
This CL also changes the timing of requestPictureInPicture() and exitPictureInPicture()
in order to be sync until the call to the service.
Bug: 919860, 930338
Change-Id: I437a060c2dd92021d514c4d6e2ffeb9f4642525b
Reviewed-on: https://chromium-review.googlesource.com/c/1409544
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631517}