Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker: 18.09.1 -> 18.09.2 #55625

Merged
merged 1 commit into from Feb 12, 2019
Merged

docker: 18.09.1 -> 18.09.2 #55625

merged 1 commit into from Feb 12, 2019

Conversation

srhb
Copy link
Contributor

@srhb srhb commented Feb 12, 2019 •
edited

Motivation for this change

CVE-2019-5736

@GrahamcOfBorg test docker

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@srhb
Copy link
Contributor Author

srhb commented Feb 12, 2019

Upstream does some weird git-bundle gymnastics in order to get the correct runc revision, but I'm pretty sure I got it right. Verification would be appreciated: docker/docker-ce@e4931e6#diff-9f3e85b3e5dd57d45832939603ad323eR25

@NeQuissimus NeQuissimus merged commit 0908038 into NixOS:master Feb 12, 2019
@carlosdagos
Copy link
Member

Thanks for this PR @srhb. Do you know the impact this CVE has on nix installations of docker? My intuition is that it should be minimal because the nix store is usually mounted as read-only, but I'm not 100% sure.

@srhb
Copy link
Contributor Author

srhb commented Feb 18, 2019

@carlosdagos I too believe we're immune, but at the time I had no way of actually testing the bug, so better safe than sorry. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeQuissimus NeQuissimus NeQuissimus approved these changes

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@srhb @carlosdagos @NeQuissimus @GrahamcOfBorg