Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

squirrel-sql: Add MSSQL driver. #55626

Merged
merged 2 commits into from May 5, 2019
Merged

squirrel-sql: Add MSSQL driver. #55626

merged 2 commits into from May 5, 2019

Conversation

cresh
Copy link
Contributor

@cresh cresh commented Feb 12, 2019

Motivation for this change

Use squirrel-sql to talk to MSSQL databases.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aanderse
Copy link
Member

aanderse commented Apr 9, 2019

@cresh I've never used squirrel-sql before but I checkout out your branch, selected "Microsoft MSSQL Server JDBC Driver" and then tried to connect to a mssql database but got the following error:

troy: JDBC Driver class not found
class java.lang.ClassNotFoundException: com.microsoft.sqlserver.jdbc.SQLServerDriver

Please advise.

@cresh
Copy link
Contributor Author

cresh commented May 3, 2019

@aanderse I've just fixed a regression, the set CLASS wasn't picked up correctly. Please give it another spin, it should work now.

aanderse
aanderse requested changes May 4, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed a few things this time around.

pkgs/servers/sql/mssql/jdbc/default.nix Outdated Show resolved Hide resolved
pkgs/servers/sql/mssql/jdbc/default.nix Outdated Show resolved Hide resolved
@aanderse
Copy link
Member

aanderse commented May 4, 2019

@aanderse I've just fixed a regression, the set CLASS wasn't picked up correctly. Please give it another spin, it should work now.

It worked now, thanks!

@cresh
Copy link
Contributor Author

cresh commented May 4, 2019

Thanks for the feedback! I've just made the requested changes.

@aanderse
Copy link
Member

aanderse commented May 5, 2019

@GrahamcOfBorg build squirrel-sql

@aanderse aanderse merged commit 31cf973 into NixOS:master May 5, 2019
@aanderse
Copy link
Member

aanderse commented May 5, 2019

Thanks for your contribution @cresh! I'll probably make use of this at some point 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cresh @aanderse @GrahamcOfBorg