Added 2 new calc() tests with background-position #15321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
dbaron,
fantasai,
FremyCompany,
frivoal,
plinss and
tabatkins
frivoal
reviewed
Feb 15, 2019
There was a problem hiding this comment.
Reviewed, and these two tests seem correct according to the spec, but that same spec says:
This section is still under discussion.
Editors (@tabatkins @fantasai) should we hold off having tests for this until the discussion concludes, or is having test helpful regardless?
(same question as in #14987)
frivoal
approved these changes
Feb 18, 2019
There was a problem hiding this comment.
Checked with @tabatkins and he confirmed it's worth having tests for that part of the specification despite the warning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.