Set click count correctly to dispatch "dblclick" event #14911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jan 17, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1413362
branch
10 times, most recently
from
09f3e0a
to
1f0c852
Compare
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1413362
branch
3 times, most recently
from
af1b05c
to
ddbdc6f
Compare
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1413362
branch
from
ddbdc6f
to
bf70a89
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1413362
branch
from
bf70a89
to
6695530
Compare
In order to dispatch the "dblclick" event to DOM by sending synthetic mouse events, we have to check the most recent two mouse press events. If their dispatched times and locations are close enough, we will set the mouse event's click count to 2, which will generate the "dblclick" event. Bug: 606367 Change-Id: I049d6463c6bf1393c9e8b496662359eeeef7682b Reviewed-on: https://chromium-review.googlesource.com/c/1413362 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#630933}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1413362
branch
from
6695530
to
d6ea34c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to dispatch the "dblclick" event to DOM by sending synthetic
mouse events, we have to check the most recent two mouse press events.
If their dispatched times and locations are close enough, we will set
the mouse event's click count to 2, which will generate the "dblclick"
event.
Bug: 606367
Change-Id: I049d6463c6bf1393c9e8b496662359eeeef7682b
Reviewed-on: https://chromium-review.googlesource.com/c/1413362
Commit-Queue: Lan Wei <lanwei@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630933}