Implemented setPlaybackRate for scroll-linked Worklet Animations. #15336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Feb 11, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1461513
branch
5 times, most recently
from
20088f1
to
0e71535
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1461513
branch
4 times, most recently
from
693efd5
to
2c02fea
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1461513
branch
from
2c02fea
to
dc6f5b6
Compare
• Updated logic of calculating initial current time of non-composited scroll-linked animations to ensure that the start time is always initialized to zero. • Changed signature of cc::ScrollTimeline::CurrentTime to return base::Optional<base::TimeTicks>. This is to enforce cc: WorkletAnimation::CurrentTime operating in the same units of base::TimeTicks and correctly handling NaN values. • Adjusted start time of scroll-linked animations when playback rate is updated. Bug: 852475 Change-Id: Iffd966c1b3ef6d821eef7cc2f6f79dae790a69f3 Reviewed-on: https://chromium-review.googlesource.com/c/1461513 Commit-Queue: Olga Gerchikov <gerchiko@microsoft.com> Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Reviewed-by: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#636836}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1461513
branch
from
dc6f5b6
to
66a6ee8
Compare
|
Taskcluster wpt-chrome-dev-stability failure is: Unstable results
|
|
Flakiness should be fixed by https://crrev.com/c/1497789 ; force-merging this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• Updated logic of calculating initial current time of non-composited scroll-linked animations to
ensure that the start time is always initialized to zero.
• Changed signature of cc::ScrollTimeline::CurrentTime to return base::Optional<base::TimeTicks>.
This is to enforce cc: WorkletAnimation::CurrentTime operating in the same units of
base::TimeTicks and correctly handling NaN values.
• Adjusted start time of scroll-linked animations when playback rate is updated.
Bug: 852475
Change-Id: Iffd966c1b3ef6d821eef7cc2f6f79dae790a69f3
Reviewed-on: https://chromium-review.googlesource.com/c/1461513
Commit-Queue: Olga Gerchikov <gerchiko@microsoft.com>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636836}