Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.contextvars: relax constraint on immutables version #55660

Merged
merged 1 commit into from Feb 23, 2019
Merged

pythonPackages.contextvars: relax constraint on immutables version #55660

merged 1 commit into from Feb 23, 2019

Conversation

catern
Copy link
Contributor

@catern catern commented Feb 12, 2019

The build was broken before since we have immutables 0.9

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@catern catern requested a review from FRidh as a code owner February 12, 2019 18:47
@matthewbauer
Copy link
Member

matthewbauer commented Feb 12, 2019 •
edited

This is very weird considering both of those packages are maintained by the same owner. Regardless if you could link to the PR here that would be helpful just for future reference:

MagicStack/contextvars#9

@catern
pythonPackages.contextvars: relax constraint on immutables version
55aa906 
The build was broken before since we have immutables 0.9
@catern
Copy link
Contributor Author

catern commented Feb 23, 2019

@FRidh ping - note that the build of contextvars is broken without this

@dotlambda
Copy link
Member

@GrahamcOfBorg build python36.pkgs.contextvars

@dotlambda dotlambda merged commit bb602e2 into NixOS:master Feb 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@catern @matthewbauer @dotlambda @GrahamcOfBorg