added calc-min-height.html reference/calc-min-height-ref.html calc-ne… #15083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sting.html calc-nesting-002.html
wpt-pr-bot
requested review from
dbaron,
fantasai,
FremyCompany,
frivoal,
plinss and
tabatkins
frivoal
requested changes
Feb 5, 2019
| box-sizing: border-box; | ||
| } | ||
| </style> | ||
| <p>crbug.com/580508: Should have a black border all round.</p> |
There was a problem hiding this comment.
The mention of "crbug.com/580508" does not help the person running the test (although it does help someone debugging something based on the test). I suggest moving it to a comment.
| https://chromium.googlesource.com/chromium/src/+/c825d655f6aaf73484f9d56e9012793f5b9668cc/third_party/WebKit/LayoutTests/css3/calc/calc-min-height.html | ||
|
|
||
| --> | ||
|
|
There was a problem hiding this comment.
an assert meta would be welcome. Maybe something like
<meta name=assert content="checks for sanity of height and min-height computations with calc()">
|
|
||
| <style> | ||
| .container { | ||
| height: 400px; |
There was a problem hiding this comment.
use spaces, not tabs. (same thing in the reference file)
Merged
|
I have created a new pull request 15320 with all of the corrections requested: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…sting.html calc-nesting-002.html
Those 3 tests and reference come from
chromium.googlesource.com/chromium/src/+/c825d655f6aaf73484f9d56e9012793f5b9668cc/third_party/WebKit/LayoutTests/css3/calc/
and are unique in the sense that they were not shared or coming from webkit repository