Fix flakiness with stale-while-revalidate tests. #15362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
annevk,
domfarolino,
jdm,
mnot,
youennf and
yutakahirano
Using cookies didn't seem reliable in the wpt test runner when it was re-run. Stop using cookies and use the server side stash instead like the rest of the fetch tests do. Increase timeout on staleness.
|
@foolip PTAL. This fixes the tests encountered on the chrome bot. |
|
@Hexcles PTAL |
Hexcles
approved these changes
Feb 14, 2019
foolip
approved these changes
Feb 15, 2019
marcoscaceres
pushed a commit
that referenced
this pull request
Jul 23, 2019
Using cookies didn't seem reliable in the wpt test runner when it was re-run. Stop using cookies and use the server side stash instead like the rest of the fetch tests do. Increase timeout on staleness.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using cookies didn't seem reliable in the wpt test runner when it was
re-run. Stop using cookies and use the server side stash instead
like the rest of the fetch tests do.
Increase timeout on staleness.