Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qemu: Add support for the Hypervisor framework on Darwin #55668

Merged
merged 1 commit into from Feb 14, 2019
Merged

qemu: Add support for the Hypervisor framework on Darwin #55668

merged 1 commit into from Feb 14, 2019

Conversation

bwolf
Copy link
Contributor

@bwolf bwolf commented Feb 12, 2019

This provides macOS native hardware acceleration to Qemu.

Motivation for this change

This adds macOS native hardware acceleration to Qemu by enabling the HypervisorFramework.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

qemu: Add support for the Hypervisor framework on Darwin
355d9a6 
This provides macOS native hardware acceleration to Qemu.
@GrahamcOfBorg GrahamcOfBorg added the 6.topic: darwin Running or building packages on Darwin label Feb 12, 2019
@veprbl
Copy link
Member

veprbl commented Feb 14, 2019

@GrahamcOfBorg build qemu

LnL7
LnL7 approved these changes Feb 14, 2019
View reviewed changes
Copy link
Member

@LnL7 LnL7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I had no idea that was a thing.

@LnL7 LnL7 merged commit 9edf760 into NixOS:master Feb 14, 2019
@LnL7
Copy link
Member

LnL7 commented Feb 14, 2019

Working as expected.

qemu-system-x86_64 -M accel=hvf -cdrom nixos-minimal-18.09.1922.97e0d53d669-x86_64-linux.iso -boot d -net nic -net user -smp 4 -m 2048 -rtc base=localtime

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer matthewbauer approved these changes

@LnL7 LnL7 LnL7 approved these changes

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@bwolf @veprbl @LnL7 @matthewbauer @GrahamcOfBorg @Janik-Haag