Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vagrant: 2.2.0 -> 2.2.3 #55596

Merged
merged 1 commit into from Feb 24, 2019
Merged

vagrant: 2.2.0 -> 2.2.3 #55596

merged 1 commit into from Feb 24, 2019

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Feb 11, 2019

Motivation for this change

Virtualbox 6.0 (from #53120) requires at least vagrant 2.2.1, and the other parts of the changelog don't look too bad either.

I had to regenerate unofficial-installation-nowarn.patch, as the lines afterwards changed, and the patch didn't apply cleanly anymore.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @globin @ryanfitzsimon @mat8913 @calbrecht

@flokli
Copy link
Contributor Author

flokli commented Feb 11, 2019

@GrahamcOfBorg build vagrant

@wkral wkral mentioned this pull request Feb 15, 2019
Closed
10 tasks
@xeji
Copy link
Contributor

xeji commented Feb 24, 2019

@GrahamcOfBorg build vagrant

@flokli flokli merged commit e48e6ca into NixOS:master Feb 24, 2019
@flokli flokli deleted the vagrant-2.2.3 branch February 24, 2019 17:27
@wkral wkral mentioned this pull request Mar 5, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@flokli @xeji @mat8913 @angristan @GrahamcOfBorg