Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shebangs and executable bits for a bunch of files #15334

Merged
merged 2 commits into from Feb 12, 2019

Conversation

LukeZielinski
Copy link
Contributor

Mostly adding missing executable bits or removing unnecessary ones. In a few cases, missing shebangs were added.

The motivation for this is to be able to cleanly import these files into the Chromium repo (where presubmit checks exist to ensure that shebangs and executable bits line up correctly).

Mostly adding missing executable bits or removing unnecessary ones.
In a few cases, missing shebangs were added.
@LukeZielinski
Copy link
Contributor Author

Let me know if there are objections to this. The other solution is to avoid importing some of these files, or adding them to internal whitelists, but this seems cleaner.

Thanks!

@Hexcles
Copy link
Member

Hexcles commented Feb 11, 2019

This looks good except the third_party bits. Files in that directory are directly imported from third parties, and changes will be overwritten next time when we upgrade these deps.

In particular, a lot of inconsistencies are in hyper/h2. Could you send a PR to https://github.com/python-hyper to fix those? Also cc @dhdavvie who works/worked on H2 stuff.

@jugglinmike
Copy link
Contributor

I'm surprised that the linter is aware of those files at all. @gsnedders you you think we should skip tools/third_party/?

@Hexcles
Copy link
Member

Hexcles commented Feb 11, 2019

@jugglinmike it's the Chromium linter that complains about inconsistent permissions & shebangs.

Copy link
Member

@gsnedders gsnedders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't change /tools/third_party, per above comments.

@gsnedders gsnedders merged commit bac4db3 into web-platform-tests:master Feb 12, 2019
@LukeZielinski LukeZielinski deleted the executable-bits branch April 3, 2019 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci docker infra manifest pywebsocket third_party wptrunner The automated test runner, commonly called through ./wpt run
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants