New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix shebangs and executable bits for a bunch of files #15334
Fix shebangs and executable bits for a bunch of files #15334
Conversation
Mostly adding missing executable bits or removing unnecessary ones. In a few cases, missing shebangs were added.
Let me know if there are objections to this. The other solution is to avoid importing some of these files, or adding them to internal whitelists, but this seems cleaner. Thanks! |
This looks good except the In particular, a lot of inconsistencies are in hyper/h2. Could you send a PR to https://github.com/python-hyper to fix those? Also cc @dhdavvie who works/worked on H2 stuff. |
I'm surprised that the linter is aware of those files at all. @gsnedders you you think we should skip |
@jugglinmike it's the Chromium linter that complains about inconsistent permissions & shebangs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't change /tools/third_party
, per above comments.
Mostly adding missing executable bits or removing unnecessary ones. In a few cases, missing shebangs were added.
The motivation for this is to be able to cleanly import these files into the Chromium repo (where presubmit checks exist to ensure that shebangs and executable bits line up correctly).