New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plasma-5: 5.14.5 -> 5.15.2 #55650
plasma-5: 5.14.5 -> 5.15.2 #55650
Conversation
Marking WIP because I'm not confident in the patch changes and don't want to mislead-- leaving commit in case useful but until it's looked through more carefully I don't think it's ready. Don't want to break folks' sessions in a small way that causes pain later :). |
Hello, could you bump this to version 5.15.1 ? |
Thanks, updated! |
Now with 5.15.2 |
As far as I can tell, 5.15.2 is working for me :) Maybe time to merge this? |
Been working for me as well, across updates tracked here. Going ahead, thanks for testing! |
This got to master now and the plasma test fails now. I suspect it's related to this update. In logs I newly see:
but that one just disappeared when I added
Any ideas? |
relevant diff of startkde between 5.14.5 and 5.15.2 :
Maybe overriding this variable to the proper path would solve the issue : https://github.com/KDE/plasma-workspace/blob/c69acc0973a5a58de5f9ea0a25fa183b09bfe6b8/startkde/startkde.cmake#L252 Relevant variable in plasma-workspace package :
|
Found the problem, this line of patch is no longer applied :
Edit: testing a fix |
@nyanloutre: are you planning to prepare a PR/patch against nixpkgs master? |
@vcunat yes but if you already have something ready go ahead (I am currently building the plasma5 test on my machine) |
No, on the contrary. I'm doing too many things already, so I'll be glad if someone else solves this one. |
See #59112 for fix |
Motivation for this change
https://www.kde.org/announcements/plasma-5.15.0.php
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)