Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use testdriver Action API in WPT pointerevent touch tests #15360

Closed
wants to merge 1 commit into from
Closed

Use testdriver Action API in WPT pointerevent touch tests #15360

wants to merge 1 commit into from

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Feb 12, 2019 •
edited by Hexcles

In order to run the web-platform-tests automatically, we will use
testdriver Action API in all the wpt to simulate inputs. Here we are
changing some pointerevent touch input tests which are doing scrolling.

Bug: 606367
Change-Id: Ibdabcbb973ac641174ca6faadccd737fa8c678b4
Reviewed-on: https://chromium-review.googlesource.com/c/1461504
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632251}

Revert "Use testdriver Action API in WPT pointerevent touch tests"

This reverts commit 6cf9dcc6ecad24b3d09b5c5398c8695a2c3867b7.

Reason for revert: Looks like this caused pointer event tests to fail in Linux Trusty:

TBR=lanwei@chromium.org,nzolghadr@chromium.org

Change-Id: If3d25e3e679ad345c6a3566d2bf6a0a962ba5568
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 606367
Reviewed-on: https://chromium-review.googlesource.com/c/1473973
Reviewed-by: Devlin rdevlin.cronin@chromium.org
Commit-Queue: Devlin rdevlin.cronin@chromium.org
Cr-Commit-Position: refs/heads/master@{#632300}

wpt-pr-bot
wpt-pr-bot approved these changes Feb 12, 2019
View reviewed changes
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1461504 branch 3 times, most recently from 8eef222 to 372e9f3 Compare February 13, 2019 22:00
@LanWei22 @chromium-wpt-export-bot
Use testdriver Action API in WPT pointerevent touch tests
408fbf5 
In order to run the web-platform-tests automatically, we will use
testdriver Action API in all the wpt to simulate inputs. Here we are
changing some pointerevent touch input tests which are doing scrolling.

Bug: 606367
Change-Id: Ibdabcbb973ac641174ca6faadccd737fa8c678b4
Reviewed-on: https://chromium-review.googlesource.com/c/1461504
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632251}
@KyleJu
Copy link
Contributor

KyleJu commented Feb 15, 2019

Flaky on Chrome and Firefox:

Unstable results

Test Subtest Results Messages
/pointerevents/pointerevent_pointerout_pen.html ERROR: 1/10, OK: 9/10
/pointerevents/pointerevent_pointerout_pen.html pointerout event received PASS: 9/10, MISSING: 1/10
/pointerevents/pointerevent_releasepointercapture_onpointercancel_touch.html ERROR: 1/10, TIMEOUT: 9/10
/pointerevents/pointerevent_releasepointercapture_onpointercancel_touch.html pointer capture is released on pointercancel NOTRUN: 9/10, MISSING: 1/10

::: Running tests in a loop 10 times : FAIL
:::
::: Test verification FAIL
:::
Traceback (most recent call last):
File "./tools/ci/taskcluster-run.py", line 85, in
main(**vars(parser.parse_args()))
File "./tools/ci/taskcluster-run.py", line 68, in main
subprocess.check_call(command)
File "/usr/lib/python2.7/subprocess.py", line 190, in check_call
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['python', './wpt', 'run', '--channel=dev', '--verify', '--affected', 'HEAD^', '--log-tbpl-level=info', '--log-tbpl=-', '-y', '--no-pause', '--no-restart-on-unexpected', '--install-fonts', '--no-headless', '--verify-log-full', 'chrome']' returned non-zero exit status 1
XIO: fatal IO error 11 (Resource temporarily unavailable) on X server ":99.0"

  after 2438333 requests (2438333 known processed) with 0 events remaining.

@Hexcles
Copy link
Member

Hexcles commented Feb 15, 2019

Reverted

@Hexcles Hexcles closed this Feb 15, 2019
@Hexcles Hexcles deleted the chromium-export-cl-1461504 branch February 15, 2019 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wpt-pr-bot wpt-pr-bot wpt-pr-bot approved these changes

Assignees
No one assigned
Labels
chromium-export pointerevents wg-pointerevents
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@chromium-wpt-export-bot @KyleJu @Hexcles @wpt-pr-bot @LanWei22