Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eclipse: 2018-09 -> 2018-12 #55575

Merged
merged 2 commits into from Feb 20, 2019
Merged

Eclipse: 2018-09 -> 2018-12 #55575

merged 2 commits into from Feb 20, 2019

Conversation

jerith666
Copy link
Contributor

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @rycee

@jerith666
eclipse: retire support for back-rev'd versions
4f9089a 
with eclipse now on a once-per-quarter release, it makes less sense to
keep a lot of old versions around in nixpkgs.  those who need them can
pin nixpkgs.
@jerith666
eclipses: 2018-09 -> 2018-12
573d6dd 
this also removes i686-linux support, as 2018-09 was the last release
officially supporting 32-bit
@jerith666 jerith666 mentioned this pull request Feb 11, 2019
Merged
@rycee
Copy link
Member

rycee commented Feb 18, 2019

This seems like a fine idea to me. Certainly cleans things up!

@GrahamcOfBorg build eclipses.eclipse-cpp eclipses.eclipse-modeling eclipses.eclipse-platform eclipses.eclipse-scala-sdk eclipses.eclipse-sdk eclipses.eclipse-java

@rycee rycee merged commit 48b5ad2 into NixOS:master Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rycee rycee Awaiting requested review from rycee

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jerith666 @rycee @GrahamcOfBorg