Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python.pkgs.matplotlib: add numpy 1.6 compat patch #55577

Merged
merged 2 commits into from Feb 11, 2019
Merged

python.pkgs.matplotlib: add numpy 1.6 compat patch #55577

merged 2 commits into from Feb 11, 2019

Conversation

timokau
Copy link
Member

@timokau timokau commented Feb 11, 2019 •
edited

Motivation for this change

Numpy deprecated asscalar in 1.16. This will be fixed in the next
matplotlib version, but to avoid deprecation warnings (and because they
are breaking the sage testsuite), it can't hurt to backport the fix
already.

Upstream: matplotlib/matplotlib#12478

The patch is already included in 3.x and will be in the next 2.x release.

Also adds a small sage patch needed for numpy 1.6 compatibility.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@timokau timokau requested a review from FRidh as a code owner February 11, 2019 20:05
@timokau
Copy link
Member Author

timokau commented Feb 11, 2019

@GrahamcOfBorg build python2.pkgs.matplotlib python3.pkgs.matplotlib

@timokau
Copy link
Member Author

timokau commented Feb 11, 2019

@GrahamcOfBorg build python2.pkgs.matplotlib python3.pkgs.matplotlib

@timokau
python.pkgs.matplotlib: add numpy 1.6 compat patch
56d92ba 
Numpy deprecated asscalar in 1.16. This will be fixed in the next
matplotlib version, but to avoid deprecation warnings (and because they
are breaking the sage testsuite), it can't hurt to backport the fix
already.

Upstream: matplotlib/matplotlib#12478
@timokau
sage: add numpy 1.16 compatibility patch
5728028 
https://trac.sagemath.org/ticket/27000
@timokau timokau merged commit a27de56 into NixOS:master Feb 11, 2019
@timokau timokau deleted the matplotlib-numpy-1.16 branch February 11, 2019 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@lovek323 lovek323 Awaiting requested review from lovek323

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timokau @GrahamcOfBorg