New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
luarocks: patch sw_vers and gcc #55580
Conversation
The sw_vers binary is not part of the stdenv and it would make builds impure based on what macOS version they where built on.
The unzip variable is only set if it's an attribute and it's a propagated input so it is already part of PATH.
/cc @teto The second commit resulted in |
@GrahamcOfBorg build luaPackages.mpack neovim luaPackages.lgi |
No Cc for me? (I agree the changes should not change anything on Linux, but I want the success of that NixOS check on record) |
Oh, didn't realise you're also a lua user 😄, we could make the patches conditional but I generally prefer not to. |
Not a heavy Lua user, but I do run some LÖVE stuff from time to time. A keen observer might have noticed I am the one who merges @teto's PRs most of the time; I am actually listed as the package maintainer for some Lua packages… (on the other hand, yeah, that means that Cc doesn't matter as ofBorg eventually sends a review request — overwriting my preexisting review) |
For the record: I pressed the «merge button», GitHub said that the merge failed (happens), «Try again» did not refresh the lack-of-conflict status, reloading shows the commit as merged. What the… convenient UI. |
@LnL7 thanks for troubleshooting this, testing via ofborg is not very productive and I was really troubled by the message saying the folder doesn't exist while it existed on linux. As for the changes themselves, when I looked in nixpkgs, some packages patch the path to sw_vers while others replace it with 10.10. Why did you choose the latter ? |
Nevermind I just saw your answer on the other issue. EDIT: ...and unzip is already in buildInputs... yeah false alert. |
Adding It should be Thanks to @alyssais for the other part of troubleshooting, too! |
I am having trouble installing neovim because of this issue. I am new to nix. Any suggestions on how I can get this fix to overcome my issue? Thanks I get:
|
Keep an eye on http://howoldis.herokuapp.com for a channel update and rollback in the meantime. But if you don't want to rollback your channel for some reason you can use this commit temporarily.
|
@LnL7 Thx for responding so fast. That is great. Which channel update am I looking for? Assume Darwin one moving to 18.10 ? Told you I am new to nix :-) |
Motivation for this change
Fixes #55553
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)