Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[js] Remove invalid tests for JavaScript built-ins #15333

Merged
merged 1 commit into from Mar 27, 2019

Conversation

jugglinmike
Copy link
Contributor

@jugglinmike jugglinmike commented Feb 11, 2019

The 2015 edition of ECMAScript modified the semantics of a number of
built-in methods to tolerate non-object values [1]. The tests asserting
a TypeError under these conditions are no longer valid. Remove them
completely in favor of the more comprehensive coverage offered by the
Test262 project.

[1] https://tc39.github.io/ecma262/#sec-additions-and-changes-that-introduce-incompatibilities-with-prior-editions

Copy link
Contributor

@Ms2ger Ms2ger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please just remove the ones that are no longer correct.

The 2015 edition of ECMAScript modified the semantics of a number of
built-in methods to tolerate non-object values [1]. The tests asserting
a TypeError under these conditions are no longer valid.

[1] https://tc39.github.io/ecma262/#sec-additions-and-changes-that-introduce-incompatibilities-with-prior-editions
@jugglinmike
Copy link
Contributor Author

I've restored the other tests. Since this invalidated part of the original commit message, I've reworded that and force-pushed the result. The original version of this branch is available here:

master...bocoup:remove-invalid-js-orig

@Ms2ger Ms2ger merged commit 32450b4 into web-platform-tests:master Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants