HTML: target=_blank implies noopener; opener support #15188

annevk · 2019-01-31T15:40:34Z

For whatwg/html#4330.

annevk · 2019-01-31T15:52:51Z

@foolip I don't know why Chrome is failing here.

foolip · 2019-02-01T11:17:09Z

From the logs:

All results

/html/semantics/links/links-created-by-a-and-area-elements/target_blank_implicit_noopener.html

Subtest	Results	Messages
	TIMEOUT
`Anchor element with target=_blank with rel=noopener`	PASS: 1/10, TIMEOUT: 9/10	`Test timed out`
`Anchor element with target=_blank with rel=opener`	PASS
`Anchor element with target=_blank with implicit rel=noopener`	FAIL	`assert_equals: expected false but got true`
`Anchor element with target=_blank with rel=opener+noopener`	PASS: 1/10, TIMEOUT: 9/10	`Test timed out`
`Anchor element with target=_blank with rel=noopener+opener`	TIMEOUT	`Test timed out`
`Area element with target=_blank with rel=noopener`	TIMEOUT	`Test timed out`
`Area element with target=_blank with rel=opener`	PASS
`Area element with target=_blank with implicit rel=noopener`	FAIL	`assert_equals: expected false but got true`
`Area element with target=_blank with rel=opener+noopener`	PASS: 2/10, TIMEOUT: 8/10	`Test timed out`
`Area element with target=_blank with rel=noopener+opener`	PASS: 1/10, TIMEOUT: 9/10	`Test timed out`

/html/semantics/links/links-created-by-a-and-area-elements/target_blank_implicit_noopener_base.html

Subtest	Results	Messages
	TIMEOUT
`Anchor element with target=_blank with rel=noopener`	PASS: 2/10, TIMEOUT: 8/10	`Test timed out`
`Anchor element with target=_blank with rel=opener`	PASS
`Anchor element with target=_blank with implicit rel=noopener`	FAIL	`assert_equals: expected false but got true`
`Anchor element with target=_blank with rel=opener+noopener`	TIMEOUT	`Test timed out`
`Anchor element with target=_blank with rel=noopener+opener`	TIMEOUT	`Test timed out`
`Area element with target=_blank with rel=noopener`	TIMEOUT	`Test timed out`
`Area element with target=_blank with rel=opener`	PASS
`Area element with target=_blank with implicit rel=noopener`	FAIL	`assert_equals: expected false but got true`
`Area element with target=_blank with rel=opener+noopener`	PASS: 1/10, TIMEOUT: 9/10	`Test timed out`
`Area element with target=_blank with rel=noopener+opener`	PASS: 3/10, TIMEOUT: 7/10	`Test timed out`

Unstable results

Test	Subtest	Results	Messages
`/html/semantics/links/links-created-by-a-and-area-elements/target_blank_implicit_noopener.html`	`Anchor element with target=_blank with rel=noopener`	PASS: 1/10, TIMEOUT: 9/10	`Test timed out`
`/html/semantics/links/links-created-by-a-and-area-elements/target_blank_implicit_noopener.html`	`Anchor element with target=_blank with rel=opener+noopener`	PASS: 1/10, TIMEOUT: 9/10	`Test timed out`
`/html/semantics/links/links-created-by-a-and-area-elements/target_blank_implicit_noopener.html`	`Area element with target=_blank with rel=opener+noopener`	PASS: 2/10, TIMEOUT: 8/10	`Test timed out`
`/html/semantics/links/links-created-by-a-and-area-elements/target_blank_implicit_noopener.html`	`Area element with target=_blank with rel=noopener+opener`	PASS: 1/10, TIMEOUT: 9/10	`Test timed out`
`/html/semantics/links/links-created-by-a-and-area-elements/target_blank_implicit_noopener_base.html`	`Anchor element with target=_blank with rel=noopener`	PASS: 2/10, TIMEOUT: 8/10	`Test timed out`
`/html/semantics/links/links-created-by-a-and-area-elements/target_blank_implicit_noopener_base.html`	`Area element with target=_blank with rel=opener+noopener`	PASS: 1/10, TIMEOUT: 9/10	`Test timed out`
`/html/semantics/links/links-created-by-a-and-area-elements/target_blank_implicit_noopener_base.html`	`Area element with target=_blank with rel=noopener+opener`	PASS: 3/10, TIMEOUT: 7/10	`Test timed out`

What is the runtime of the test, might it be close to timing out?

annevk · 2019-02-01T11:30:10Z

It's opening a bunch of windows and reporting results via BroadcastChannel. Should be relatively quick, but might depend on other things?

foolip · 2019-02-01T12:30:33Z

I was able to reproduce the failure with ./wpt run --verify --channel dev --binary which google-chrome-unstable --log-tbpl - chrome /html/semantics/links/links-created-by-a-and-area-elements/target_blank_implicit_noopener.html.

I didn't time it, but each iteration seemed to take ~10s, and here's the output:

All results

/html/semantics/links/links-created-by-a-and-area-elements/target_blank_implicit_noopener.html

Subtest	Results	Messages
	TIMEOUT
`Anchor element with target=_blank with rel=noopener`	PASS: 2/10, TIMEOUT: 8/10	`Test timed out`
`Anchor element with target=_blank with rel=opener`	PASS
`Anchor element with target=_blank with implicit rel=noopener`	FAIL	`assert_equals: expected false but got true`
`Anchor element with target=_blank with rel=opener+noopener`	PASS: 5/10, TIMEOUT: 5/10	`Test timed out`
`Anchor element with target=_blank with rel=noopener+opener`	PASS: 7/10, TIMEOUT: 3/10	`Test timed out`
`Area element with target=_blank with rel=noopener`	TIMEOUT	`Test timed out`
`Area element with target=_blank with rel=opener`	PASS
`Area element with target=_blank with implicit rel=noopener`	FAIL	`assert_equals: expected false but got true`
`Area element with target=_blank with rel=opener+noopener`	PASS: 9/10, TIMEOUT: 1/10	`Test timed out`
`Area element with target=_blank with rel=noopener+opener`	PASS: 6/10, TIMEOUT: 4/10	`Test timed out`

Unstable results

Test	Subtest	Results	Messages
`/html/semantics/links/links-created-by-a-and-area-elements/target_blank_implicit_noopener.html`	`Anchor element with target=_blank with rel=noopener`	PASS: 2/10, TIMEOUT: 8/10	`Test timed out`
`/html/semantics/links/links-created-by-a-and-area-elements/target_blank_implicit_noopener.html`	`Anchor element with target=_blank with rel=opener+noopener`	PASS: 5/10, TIMEOUT: 5/10	`Test timed out`
`/html/semantics/links/links-created-by-a-and-area-elements/target_blank_implicit_noopener.html`	`Anchor element with target=_blank with rel=noopener+opener`	PASS: 7/10, TIMEOUT: 3/10	`Test timed out`
`/html/semantics/links/links-created-by-a-and-area-elements/target_blank_implicit_noopener.html`	`Area element with target=_blank with rel=opener+noopener`	PASS: 9/10, TIMEOUT: 1/10	`Test timed out`
`/html/semantics/links/links-created-by-a-and-area-elements/target_blank_implicit_noopener.html`	`Area element with target=_blank with rel=noopener+opener`	PASS: 6/10, TIMEOUT: 4/10	`Test timed out`

Does the test run quickly on Firefox?

annevk · 2019-02-01T12:55:36Z

It does. It shouldn't run any longer than the per-test timeout though.

foolip · 2019-02-01T21:22:27Z

I guess that one could only start trying to reproduce and minify until the cause is clear. Not sure who a good contact working on Chromium would be. @tkent-google, do you know who's are this is?

...emantics/links/links-created-by-a-and-area-elements/target_blank_implicit_noopener_base.html

tkent-google · 2019-02-04T01:24:33Z

@tkent-google, do you know who's are this is?

If it's a BroadcastChannel issue, renderer/modules/broadcastchannel/OWNERS is the contact. If it's a window managing issue, no one is responsible and HTML team can be a fallback.

Anyway, I have a comment on the test.

...emantics/links/links-created-by-a-and-area-elements/target_blank_implicit_noopener_base.html

annevk · 2019-02-04T10:09:26Z

Should be all good now, from a test perspective. Dunno about Taskcluster though.

foolip · 2019-02-04T11:29:21Z

I'll go ahead and admin merge this. If it's also flaky in Chromium (content_shell) it'll be easier to diagnose there.

foolip · 2019-02-04T11:30:13Z

Uh, actually, whatwg/html#4330 is open. @annevk let me know when I should merge this.

annevk · 2019-02-07T12:20:39Z

This can now be merged. I'll be merging the HTML PR shortly. A Chromium bug is already filed as per that PR.

For squash and merge please only use the commit message from the initial commit.

This reduces the number of coupled top-level browsing contexts and thereby reduces the attack surface somewhat. Tests: web-platform-tests/wpt#15188. Fixes #4078.

foolip · 2019-02-11T13:33:11Z

@annevk squash merged!

annevk · 2019-02-11T13:37:19Z

Takk!

This reduces the number of coupled top-level browsing contexts and thereby reduces the attack surface somewhat. Tests: web-platform-tests/wpt#15188. Fixes whatwg#4078.

ericlaw1979 · 2019-05-25T13:07:59Z

The test case does:

<img src="" /> <area /> </img>

Is that valid? (It doesn't seem to create an image map, and there's a /> that ends the image tag then an explicit </img> at the end.

zcorpan · 2019-05-26T11:03:40Z

</img> is invalid HTML. The association needs to be done with <img usemap=#foo><map name=foo>

annevk · 2019-05-27T09:08:02Z

It's indeed bogus, but shouldn't affect the test. I'll create a PR to clean that up a bit though.

As pointed out in #15188 (comment) it was a bit confusing (and wrong).

…ener tests, a=testonly Automatic update from web-platform-tests Editorial: cleanup some area opener/noopener tests (#17025) As pointed out in web-platform-tests/wpt#15188 (comment) it was a bit confusing (and wrong). -- wp5At-commits: 36f2a92acd0f8214dfcddfffd970f73c30efd5bf wpt-pr: 17025

As pointed out in #15188 (comment) it was a bit confusing (and wrong).

…ener tests, a=testonly Automatic update from web-platform-tests Editorial: cleanup some area opener/noopener tests (#17025) As pointed out in web-platform-tests/wpt#15188 (comment) it was a bit confusing (and wrong). -- wp5At-commits: 36f2a92acd0f8214dfcddfffd970f73c30efd5bf wpt-pr: 17025 UltraBlame original commit: b17abf34f8216da67984b02fd15a79f412aa5a9e

HTML: target=_blank implies noopener; opener support

75d874a

For whatwg/html#4330.

wpt-pr-bot added the html label Jan 31, 2019

wpt-pr-bot assigned jdm Jan 31, 2019

wpt-pr-bot requested review from domenic, foolip, jdm, jgraham, zcorpan and zqzhang January 31, 2019 15:40

domenic reviewed Feb 2, 2019

View reviewed changes

...emantics/links/links-created-by-a-and-area-elements/target_blank_implicit_noopener_base.html Outdated Show resolved Hide resolved

tkent-google reviewed Feb 4, 2019

View reviewed changes

...emantics/links/links-created-by-a-and-area-elements/target_blank_implicit_noopener_base.html Outdated Show resolved Hide resolved

annevk added 2 commits February 4, 2019 11:02

fix typo

13f6b84

add some noreferrer tests and fix titles of base tests

6aed814

annevk assigned foolip and unassigned jdm Feb 7, 2019

CYBAI mentioned this pull request Feb 7, 2019

Make target=_blank imply noopener; support opener servo/servo#22845

Closed

foolip merged commit e81ca20 into master Feb 11, 2019

foolip deleted the annevk/target-blank-no-opener branch February 11, 2019 13:33

annevk added a commit that referenced this pull request May 27, 2019

Editorial: cleanup some area opener/noopener tests

2b2183e

As pointed out in #15188 (comment) it was a bit confusing (and wrong).

annevk mentioned this pull request May 27, 2019

Editorial: cleanup some area opener/noopener tests #17025

Merged

foolip pushed a commit that referenced this pull request May 27, 2019

Editorial: cleanup some area opener/noopener tests (#17025)

36f2a92

As pointed out in #15188 (comment) it was a bit confusing (and wrong).

marcoscaceres pushed a commit that referenced this pull request Jul 23, 2019

Editorial: cleanup some area opener/noopener tests (#17025)

8677b52

As pointed out in #15188 (comment) it was a bit confusing (and wrong).

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HTML: target=_blank implies noopener; opener support #15188

HTML: target=_blank implies noopener; opener support #15188

annevk commented Jan 31, 2019

annevk commented Jan 31, 2019

foolip commented Feb 1, 2019

annevk commented Feb 1, 2019

foolip commented Feb 1, 2019

annevk commented Feb 1, 2019

foolip commented Feb 1, 2019 •

edited

tkent-google commented Feb 4, 2019

annevk commented Feb 4, 2019

foolip commented Feb 4, 2019

foolip commented Feb 4, 2019

annevk commented Feb 7, 2019

foolip commented Feb 11, 2019

annevk commented Feb 11, 2019

ericlaw1979 commented May 25, 2019 •

edited

zcorpan commented May 26, 2019

annevk commented May 27, 2019

HTML: target=_blank implies noopener; opener support #15188

HTML: target=_blank implies noopener; opener support #15188

Conversation

annevk commented Jan 31, 2019

annevk commented Jan 31, 2019

foolip commented Feb 1, 2019

All results

/html/semantics/links/links-created-by-a-and-area-elements/target_blank_implicit_noopener.html

/html/semantics/links/links-created-by-a-and-area-elements/target_blank_implicit_noopener_base.html

Unstable results

annevk commented Feb 1, 2019

foolip commented Feb 1, 2019

All results

/html/semantics/links/links-created-by-a-and-area-elements/target_blank_implicit_noopener.html

Unstable results

annevk commented Feb 1, 2019

foolip commented Feb 1, 2019 • edited

tkent-google commented Feb 4, 2019

annevk commented Feb 4, 2019

foolip commented Feb 4, 2019

foolip commented Feb 4, 2019

annevk commented Feb 7, 2019

foolip commented Feb 11, 2019

annevk commented Feb 11, 2019

ericlaw1979 commented May 25, 2019 • edited

zcorpan commented May 26, 2019

annevk commented May 27, 2019

foolip commented Feb 1, 2019 •

edited

ericlaw1979 commented May 25, 2019 •

edited