Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ninja: patch to fix w/musl, see upstream issue #55619

Merged
merged 1 commit into from Feb 12, 2019
Merged

ninja: patch to fix w/musl, see upstream issue #55619

merged 1 commit into from Feb 12, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Feb 12, 2019 •
edited

Motivation for this change

Fix w/musl, possibly fix elsewhere.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill
Copy link
Member Author

dtzWill commented Feb 12, 2019

LGTM, build-tested with and without musl and built a number of packages with the result (not exhaustive or systematic, just whatever in normal system closure) and so far so good.

Any reason to delay on this?

thoughtpolice
thoughtpolice approved these changes Feb 12, 2019
View reviewed changes
Copy link
Member

@thoughtpolice thoughtpolice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@dtzWill
Copy link
Member Author

dtzWill commented Feb 12, 2019

Great, thanks!

@dtzWill dtzWill merged commit 173d12a into NixOS:staging Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thoughtpolice thoughtpolice thoughtpolice approved these changes

@bjornfor bjornfor Awaiting requested review from bjornfor

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @thoughtpolice @GrahamcOfBorg