nixos/dockerPreloader: guard the entire implemetation with mkIf on image list #55589
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I've been seeing issues where existing preloaded images in the docker daemon gets garbled when restarting
docker.service
. This happens because dockerPreloader overwritesrepository.json
and it is not designed to preserve any images that might be pre-loaded before it runs.example:
Currently, there's no way of disabling the dockerPreloader. But I think it is ok to assume that if the list of images to preload is empty, we can safely drop configuring the systemd unit for the preloader. What do you say @nlewo?
cc @srhb
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)