New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New package for `yubikey-manager-qt` #55587

Merged

Ma27 merged 4 commits into NixOS:master from avdv:pkg/yubikey-manager-qt

Feb 15, 2019

Member

avdv commented Feb 11, 2019

Motivation for this change

I own a few Yubikeys, USB keys for FIDO2 U2F auth. There is a new graphical manager appliation based on Qt5 (similar to yubikey-manager-neo) from Yubico.

This is my first try writing a Nix expression for a new package, a probably made some mistakes. Please advice.

Things done

avdv added 2 commits

February 11, 2019 23:17


          maintainers: add cbley

ad30ed6


          yubikey-manager-qt: init at 1.1.0

delroth reviewed

View reviewed changes

Contributor

delroth left a comment

Did a quick first review pass -- I don't know anything about Qt or Python packaging in Nix, so mostly addressing the low hanging fruits :-)

pkgs/tools/misc/yubikey-manager-qt/default.nix Outdated Show resolved Hide resolved

pkgs/tools/misc/yubikey-manager-qt/default.nix Outdated

+                version = "1.1.0";
+                src = fetchurl {
+                  url = "https://developers.yubico.com/yubikey-manager-qt/Releases/yubikey-manager-qt-${version}.tar.gz";

Contributor

delroth Feb 11, 2019

Just ${name}.tar.gz?

Member Author

avdv Feb 12, 2019

Yes.

pkgs/tools/misc/yubikey-manager-qt/default.nix Outdated Show resolved Hide resolved

pkgs/tools/misc/yubikey-manager-qt/default.nix Outdated Show resolved Hide resolved

pkgs/tools/misc/yubikey-manager-qt/default.nix Outdated

+                ];
+              in stdenv.mkDerivation rec {
+                name = "${pname}-${version}";

Contributor

delroth Feb 11, 2019

Doesn't seem like pname is used anywhere else, just inline it in here?

Member Author

avdv Feb 12, 2019 •

edited

That seems to be a standard attribute, given what @Ma27 said about the name attribute. So, I am removing name assignment.

Member

Ma27 Feb 12, 2019

I obviously didn't explain this well enough: you can either use pname (and version) which is concatenated to ${pname}-${version} or simply use a name attribute. The first option has been implemented for convenience reasons, the latter is more commonly used.

pkgs/tools/misc/yubikey-manager-qt/default.nix Outdated Show resolved Hide resolved

Ma27 requested changes

View reviewed changes

Member

Ma27 left a comment

Thanks a lot for your contribution. Unfortunately I get the following error when starting ./result/bin/ykman-gui (after removing the duplicated homepage entry from meta):

QQmlApplicationEngine failed to load component
qrc:/qml/main.qml:1 module "QtQuick" is not installed
qrc:/qml/main.qml:6 module "QtQuick.Controls.Material" is not installed
qrc:/qml/main.qml:4 module "Qt.labs.settings" is not installed
qrc:/qml/main.qml:2 module "QtQuick.Controls" is not installed
qrc:/qml/main.qml:7 module "QtQuick.Window" is not installed
qrc:/qml/main.qml:3 module "QtQuick.Layouts" is not installed
qrc:/qml/main.qml:5 module "Qt.labs.platform" is not installed
qrc:/qml/main.qml:1 module "QtQuick" is not installed
qrc:/qml/main.qml:6 module "QtQuick.Controls.Material" is not installed
qrc:/qml/main.qml:4 module "Qt.labs.settings" is not installed
qrc:/qml/main.qml:2 module "QtQuick.Controls" is not installed
qrc:/qml/main.qml:7 module "QtQuick.Window" is not installed
qrc:/qml/main.qml:3 module "QtQuick.Layouts" is not installed
qrc:/qml/main.qml:5 module "Qt.labs.platform" is not installed
qrc:/qml/main.qml:1 module "QtQuick" is not installed
qrc:/qml/main.qml:6 module "QtQuick.Controls.Material" is not installed
qrc:/qml/main.qml:4 module "Qt.labs.settings" is not installed
qrc:/qml/main.qml:2 module "QtQuick.Controls" is not installed
qrc:/qml/main.qml:7 module "QtQuick.Window" is not installed
qrc:/qml/main.qml:3 module "QtQuick.Layouts" is not installed
qrc:/qml/main.qml:5 module "Qt.labs.platform" is not installed
qrc:/qml/main.qml:1 module "QtQuick" is not installed
qrc:/qml/main.qml:6 module "QtQuick.Controls.Material" is not installed
qrc:/qml/main.qml:4 module "Qt.labs.settings" is not installed
qrc:/qml/main.qml:2 module "QtQuick.Controls" is not installed
qrc:/qml/main.qml:7 module "QtQuick.Window" is not installed
qrc:/qml/main.qml:3 module "QtQuick.Layouts" is not installed
qrc:/qml/main.qml:5 module "Qt.labs.platform" is not installed
qrc:/qml/main.qml:1 module "QtQuick" is not installed
qrc:/qml/main.qml:6 module "QtQuick.Controls.Material" is not installed
qrc:/qml/main.qml:4 module "Qt.labs.settings" is not installed
qrc:/qml/main.qml:2 module "QtQuick.Controls" is not installed
qrc:/qml/main.qml:7 module "QtQuick.Window" is not installed
qrc:/qml/main.qml:3 module "QtQuick.Layouts" is not installed
qrc:/qml/main.qml:5 module "Qt.labs.platform" is not installed
qrc:/qml/main.qml:1 module "QtQuick" is not installed
qrc:/qml/main.qml:6 module "QtQuick.Controls.Material" is not installed
qrc:/qml/main.qml:4 module "Qt.labs.settings" is not installed
qrc:/qml/main.qml:2 module "QtQuick.Controls" is not installed
qrc:/qml/main.qml:7 module "QtQuick.Window" is not installed
qrc:/qml/main.qml:3 module "QtQuick.Layouts" is not installed
qrc:/qml/main.qml:5 module "Qt.labs.platform" is not installed
qrc:/qml/main.qml:1 module "QtQuick" is not installed
qrc:/qml/main.qml:6 module "QtQuick.Controls.Material" is not installed
qrc:/qml/main.qml:4 module "Qt.labs.settings" is not installed
qrc:/qml/main.qml:2 module "QtQuick.Controls" is not installed
qrc:/qml/main.qml:7 module "QtQuick.Window" is not installed
qrc:/qml/main.qml:3 module "QtQuick.Layouts" is not installed
qrc:/qml/main.qml:5 module "Qt.labs.platform" is not installed

[1]    24343 segmentation fault  ./result/bin/ykman-gui

pkgs/tools/misc/yubikey-manager-qt/default.nix Outdated Show resolved Hide resolved

pkgs/tools/misc/yubikey-manager-qt/default.nix Outdated Show resolved Hide resolved

pkgs/tools/misc/yubikey-manager-qt/default.nix Outdated Show resolved Hide resolved

pkgs/tools/misc/yubikey-manager-qt/default.nix Outdated

+                  wrapProgram $out/bin/ykman-gui \
+                    --prefix PYTHONPATH : "$program_PYTHONPATH" \
+                    --prefix LD_PRELOAD : "${yubikey-personalization}/lib/libykpers-1.so" \
+                    --prefix LD_LIBRARY_PATH : "${stdenv.lib.getLib pcsclite}/lib:${yubikey-personalization}/lib" \

Member

Ma27 Feb 11, 2019

Actually an appropriate ELF header is produced during the build. But I need to recheck this as soon as we got this working properly :)

Member

Ma27 Feb 12, 2019

Again, isn't pcsclite a dependency (and shouldn't be added using LD_LIBRARY_PATH)? Also I'm not sure if LD_PRELOAD is actually needed.

Member

Ma27 commented Feb 11, 2019

...and @delroth was slightly faster than me 😅


          fixup! yubikey-manager-qt: init at 1.1.0

d89634a

Member Author

avdv commented Feb 12, 2019

@Ma27 and @delroth thank you so much! I (hopefully) fixed all the issues you mentioned and pushed a fixup commit. I'll squash the last two commits on your mark.

GrahamcOfBorg added 8.has: package (new) 11.by: package-maintainer 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 labels

Member

Ma27 commented Feb 12, 2019

Thanks a lot for stepping through the feedback. Although the program starts for me, it doesn't detect a YubiKey for me (yubikey-personalization-gui is installed in my nixos-config and detects it). Am I missing any additional udev rules? In that case we should document this i.e. in doc/package-notes.xml.

Member Author

avdv commented Feb 12, 2019 •

edited

Thanks a lot for stepping through the feedback. Although the program starts for me, it doesn't detect a YubiKey for me (yubikey-personalization-gui is installed in my nixos-config and detects it). Am I missing any additional udev rules? In that case we should document this i.e. in doc/package-notes.xml.

I also had a hard time to figure this out...

You need to have the pcscd service (from pcsclite) configured for the program to work. (services.systemd.pcsclite.enabled = true; if I remember correctly -- I am not at home right now)

And you need the udev rules from libu2f-host enabled for Firefox to recognize the stick for authentication. (services.udev.packages = [ libu2f-hosts ];)

update:

This is the configuration I have in place:

  services.pcscd.enable = true;
  services.pcscd.plugins = [ pkgs.acsccid pkgs.ccid ];

  services.udev.packages = [ pkgs.libu2f-host ];

I think pkgs.acsccid is not really needed for a Yubikey.

Member

Ma27 commented Feb 12, 2019

The service you're reffering to is called pcscd. With it enabled the GUI seems to work 👍

Member

dtzWill commented Feb 14, 2019

Works here too, thanks!


          yubikey-manager-qt: cleanup

703e876

* Explicitly specify all QT dependencies rather than import from the
  `qt5` attr set. This makes overrides of a single library easier.

* Drop the superfluous `with stdenv` expression and reference lib or
  stdenv itself where possible.

* Don't manually configure shared libraries to load. This is mostly done
  automatically during the build steps.

Member

Ma27 commented Feb 15, 2019

I pushed a second commit onto your branch (that can be easily removed if needed) that does some minor cleanup as explained in the commit message. If the commit is fine for you and with it the package remains functional for you, I'd approve and merge :)

Member Author

avdv commented Feb 15, 2019

@Ma27 LGTM, and still works for me, thank you!

Ma27 approved these changes

View reviewed changes

Ma27 merged commit 2e359d9 into NixOS:master

Member

Ma27 commented Feb 15, 2019

@avdv thanks!

bricewge mentioned this pull request

yubikey-manager-gui: revert part of 2e359d9 #62261

Merged

10 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment