Reland "bluetooth: FakeBluetoothChooser impl." #15338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Feb 11, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-986593
branch
2 times, most recently
from
ebae5ab
to
603a89f
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-986593
branch
from
603a89f
to
e997823
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-986593
branch
9 times, most recently
from
243847b
to
44814d6
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-986593
branch
from
44814d6
to
9784c0c
Compare
This is a reland of 6a337f19713e049cd42969b0c909c59aff4146cd This previous change caused tests to fail because of a Mojo validation error, which is now taken care of by allowing the Bluetooth tests to use the path to the generated Mojom files. Design doc: https://docs.google.com/document/d/1XFl_4ZAgO8ddM6U53A9AfUuZeWgJnlYD5wtbXqEpzeg Original change's description: > bluetooth: FakeBluetoothChooser impl. > > Implements the interfaces that FakeBluetoothChooser overrides. The > mojom::FakeBluetoothChooser overrides are implemented by running > |event_handler_| with the appropriate arguments. The BluetoothChooser > overrides do nothing at the moment, since the base class is only meant > to update the chooser user interface. > > This change also begins to partially convert a Bluetooth chooser test to test > the interface and deletes the temporary tests that were created to test this > API. > > This change reverts commit 42624492cd5e80855f1dd3a5a8146b258def2c2a, which > reverted the original change. The original change caused the > new-scan-device-added.html test to fail because of a Mojo validation error > resulting from not updating the > third_party/.../external/wpt/resources/chromium/fake_bluetooth_chooser.mojom.js > file needed by the test. > > Bug: 719827, 719826, 824704, 826787 > Change-Id: I5e5cce7e809b4d71216c2d074a417ea822d5e527 > Reviewed-on: https://chromium-review.googlesource.com/985195 > Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#546729} Bug: 719827, 719826, 824704, 826787 Change-Id: If63a681becbb2ac0f646a11ea20b1db18d42395d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/986593 Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#655081}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-986593
branch
from
9784c0c
to
10ab8bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a reland of 6a337f19713e049cd42969b0c909c59aff4146cd
This previous change caused tests to fail because of a Mojo validation
error, which is now taken care of by allowing the Bluetooth tests to
use the path to the generated Mojom files.
Design doc:
https://docs.google.com/document/d/1XFl_4ZAgO8ddM6U53A9AfUuZeWgJnlYD5wtbXqEpzeg
Original change's description:
Bug: 719827, 719826, 824704, 826787
Change-Id: If63a681becbb2ac0f646a11ea20b1db18d42395d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/986593
Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#655081}