Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.shodan: init at 1.10.4 #54871

Merged
merged 1 commit into from Feb 7, 2019
Merged

pythonPackages.shodan: init at 1.10.4 #54871

merged 1 commit into from Feb 7, 2019

Conversation

lihop
Copy link
Member

@lihop lihop commented Jan 29, 2019

Python library and command-line interface for Shodan.

Motivation for this change

Library missing from nixpkgs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lihop lihop requested a review from FRidh as a code owner January 29, 2019 04:43
@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.shodan python3.pkgs.shodan

Lassulus
Lassulus approved these changes Feb 7, 2019
View reviewed changes
Copy link
Member

@Lassulus Lassulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with nix-review, supplied my api key and ran some queries with the shodan executable

@dotlambda dotlambda merged commit 714b785 into NixOS:master Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda requested changes

@Lassulus Lassulus Lassulus approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lihop @dotlambda @Lassulus @GrahamcOfBorg