cmake: 3.12.1 -> 3.12.2 #54836
Closed
cmake: 3.12.1 -> 3.12.2 #54836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 28, 2019
Closed
|
@stites Could you please re-make this pull request against the |
|
Will do, I'll also bump to 3.13.4 which is the latest stable cmake release (see #55060). Sorry about the delay! |
|
Submitted to staging, see #56059 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Trying to use cudatoolkit-10 with magma and running into a bug solved by upgrading cmake. Reference: clab/dynet#1457 (comment)
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)I'm not 100% sure how to test this locally. I tried checking
nix path-info -Sandnix-shell -p nox --run "nox-review wip". nox returnsNo uncommit changes. Did you mean to use the "--against" option?and I'm a bit too new at nix to figure it out. I figure this will impact most packages and it might be easier to let CI do this. I have verified the binary on Ubuntu and NixOS, and have passed the current blocker I am facing with magma+cuda-10.