Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zsh: fix for infinite recursion in VCS_INFO_detect_p4 #54831

Merged
merged 1 commit into from Jan 29, 2019
Merged

Conversation

ptrhlm
Copy link
Contributor

@ptrhlm ptrhlm commented Jan 28, 2019

Motivation for this change

Fixes following error for grml-zsh users:

VCS_INFO_detect_p4:79: maximum nested function level reached; increase FUNCNEST?
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Fixes following error for grml-zsh users:
VCS_INFO_detect_p4:79: maximum nested function level reached; increase FUNCNEST?
@infinisil
Copy link
Member

What's the status of this upstream?

@ptrhlm
Copy link
Contributor Author

ptrhlm commented Jan 28, 2019

What's the status of this upstream?

Here's message with patch from zsh dev: http://www.zsh.org/mla/workers/2019/msg00058.html

It seems they've noticed the bug too late. Probably will be fixed in the next release

@infinisil
Copy link
Member

Is there a reason this patch is necessary in nixpkgs? What differentiates this from every other bug in zsh whose fixes aren't released yet?

@dtzWill
Copy link
Member

dtzWill commented Jan 29, 2019

  • It causes error or segfault in popular configurations
  • It has also been applied in other distributions, or at least Debian.

Question seems a bit unfair? I mean presumably this fix is at least motivated by impacting the submitting user. While yes we don't chase every commit I don't think we're so release-only that we leave breakage with known upstream fixes?

FWIW this was also fixed almost immediately after 5.7 was posted. I'd be running with this patch myself if I didn't kludge around the issue in my config already :).

@infinisil
Copy link
Member

Alright, sorry didn't want it to sound like that. This problem seemed pretty non-fatal to me (because I thought it would only occur if you ran a git specific command outside of a git repo), but I think I get it now that this error happens all the time, which then sounds more reasonable to fix.

@pSub pSub merged commit 3c6d358 into NixOS:master Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants