Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

awesome: 4.2 -> 4.3, don't clutter PATH, touchup lua paths #54867

Merged
merged 2 commits into from Jan 29, 2019
Merged

awesome: 4.2 -> 4.3, don't clutter PATH, touchup lua paths #54867

merged 2 commits into from Jan 29, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jan 29, 2019 •
edited

Motivation for this change

Should be compatible but even so may want to review
release notes to take advantage of the new goodness:

https://github.com/awesomeWM/awesome/releases/tag/v4.3

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill
awesome: 4.2 -> 4.3
cdb9adb
@dtzWill
awesome: fixup lua paths, don't add random utilities to PATH
17d3eb2 
Lua path changes needed to fix build,
removing PATH clutter while visiting this code since doesn't belong.
rasendubi
rasendubi approved these changes Jan 29, 2019
View reviewed changes
Copy link
Member

@rasendubi rasendubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome!

@rasendubi
Copy link
Member

Running awesome-4.3 right now. Works like a charm.

@rasendubi rasendubi merged commit c19693b into NixOS:master Jan 29, 2019
@psychon
Copy link
Contributor

psychon commented Feb 14, 2019

Uhm, asciidoc was replaced with asciidoctor (due to asciidoc being deprecated), thus asciidoc can be removed from the build inputs.

@dtzWill
Copy link
Member Author

dtzWill commented Feb 14, 2019

Uhm, asciidoc was replaced with asciidoctor (due to asciidoc being deprecated), thus asciidoc can be removed from the build inputs.

Whoops, sorry! Will submit a PR fixing this shortly :).

@dtzWill dtzWill mentioned this pull request Feb 14, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rasendubi rasendubi rasendubi approved these changes

@lovek323 lovek323 Awaiting requested review from lovek323

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dtzWill @rasendubi @psychon @GrahamcOfBorg