Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openra: updated engines and mods #54858

Merged
merged 1 commit into from Feb 3, 2019
Merged

openra: updated engines and mods #54858

merged 1 commit into from Feb 3, 2019

Conversation

msteen
Copy link
Contributor

@msteen msteen commented Jan 29, 2019

Motivation for this change

The bleed version of OpenRA had the wrong hash and most mods have had updates. The Zenity error now shows actual newlines rather than \n. Mods have been updated automatically with a script, which is included in the PR.

Update 2: Downgraded kknd to a older commit and upgraded dr to an even newer commit to make them both work. They should now all run.
Update: @fusion809 tested them and found that only kknd and dr need fixing.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@fpletz fpletz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@fpletz fpletz merged commit 92e64d5 into NixOS:master Feb 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants