Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

magma: 2.0.2 -> 2.0.2, 2.3.0, 2.4.0, + mklSupport #54846

Closed
wants to merge 1 commit into from

Conversation

stites
Copy link
Member

@stites stites commented Jan 28, 2019

Motivation for this change

I am trying to use magma with cuda-10, which involved bumping magma to 2.3.0 to support my gpu's architecture. Note that this PR uses the default cudatoolbelt so nuances addressed in #54836 do not apply here.

From what I can see on their website the current stable version seems to be 2.3.0. That said, it looks like 2.4.0 is complete and v2.5.0 is in active development. I've included all of the versions listed, except for 2.5.0, using cudnn/default.nix as a reference for the code.

Magma also supports mkl, I've added it as an optional dependency.

Again, from #54836, I'm not terribly affluent with building nix packages (many kudos to @tstat for helping me get through the build errors). I've tested this on ubuntu with 2.3.0 and 2.4.0 with defaults, mkl, and with cuda-10. I can't build 2.0.2 on my machine because of an incompatible gpu architecture.

CI should break because I'm not sure how best to package this in pkgs/top-level/all-packages.nix, I'm hoping for some feedback/guidelines here.

Thank you!
-s

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@prusnak
Copy link
Member

prusnak commented Sep 7, 2019

Is this still relevant as #61347 is merged now?

@stites
Copy link
Member Author

stites commented Sep 7, 2019

Yes, I'll close this now. Hopefully, the DMAGMA_WITH_MKL=true cmake flag is implicitly set when an MKLROOT is set.

@stites stites closed this Sep 7, 2019
@stites stites deleted the magma-bump branch September 7, 2019 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants