magma: 2.0.2 -> 2.0.2, 2.3.0, 2.4.0, + mklSupport #54846
Closed
+78
−45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I am trying to use magma with cuda-10, which involved bumping magma to 2.3.0 to support my gpu's architecture. Note that this PR uses the default
cudatoolbelt
so nuances addressed in #54836 do not apply here.From what I can see on their website the current stable version seems to be 2.3.0. That said, it looks like 2.4.0 is complete and v2.5.0 is in active development. I've included all of the versions listed, except for 2.5.0, using cudnn/default.nix as a reference for the code.
Magma also supports mkl, I've added it as an optional dependency.
Again, from #54836, I'm not terribly affluent with building nix packages (many kudos to @tstat for helping me get through the build errors). I've tested this on ubuntu with 2.3.0 and 2.4.0 with defaults, mkl, and with cuda-10. I can't build 2.0.2 on my machine because of an incompatible gpu architecture.
CI should break because I'm not sure how best to package this in
pkgs/top-level/all-packages.nix
, I'm hoping for some feedback/guidelines here.Thank you!
-s
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)