Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emby: 3.5.3.0 -> 4.0.1.0 #54833

Closed
wants to merge 1 commit into from
Closed

Conversation

r-ryantm
Copy link
Contributor

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/emby/versions.

meta.description for emby is: '"MediaBrowser - Bring together your videos, music, photos, and live television"'.

Checks done (click to expand)
Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
emby

Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/0qp148w14gsxyxfah852cm3wfks13hnc-emby-4.0.1.0 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)

Or, build yourself:

nix-build -A emby https://github.com/r-ryantm/nixpkgs/archive/8c7b5720403642dc7a8c741a8e22ec27135dae24.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/0qp148w14gsxyxfah852cm3wfks13hnc-emby-4.0.1.0
ls -la /nix/store/0qp148w14gsxyxfah852cm3wfks13hnc-emby-4.0.1.0/bin

cc @fadenb for testing.

Semi-automatic update generated by
https://github.com/ryantm/nixpkgs-update tools. This update was made
based on information from
https://repology.org/metapackage/emby/versions
@etu
Copy link
Contributor

etu commented Jan 29, 2019

This shouldn't be merged as is because Emby has changed their license from GPL to something else.

Wikipedia calls it plain "Proprietary": https://en.wikipedia.org/wiki/Emby

The 4.x is also not in https://github.com/MediaBrowser/Emby where I think the actual development was.

This has also been discussed in #51832.

@worldofpeace
Copy link
Contributor

The 4.x is also not in https://github.com/MediaBrowser/Emby where I think the actual development was.

They actually keep their releases here.

@etu
Copy link
Contributor

etu commented Jan 29, 2019

The 4.x is also not in https://github.com/MediaBrowser/Emby where I think the actual development was.

They actually keep their releases here.

Yeah, but that doesn't seem to contain any source or license.

I tried to download the .tar.gz just now which contained a more or less empty readme and some apk's.

Emby.Releases-4.0.1.0/
├── android
│   ├── MediaBrowser.Mobile-googlearmv7-release.apk
│   └── MediaBrowser.Mobile-googlex86-release.apk
└── README.md

So there's no license information what so ever since the 4.x is not in the repo that looks like the development repo or bundled with the actual binaries.

Copy link
Contributor

@xeji xeji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clarify license situation

@spacekookie
Copy link
Member

Would it be sensible to make this into a new package? That way people who don't allow unfree software on their systems could remain on 3.5, instead of being forced into a non-free license

@etu
Copy link
Contributor

etu commented Mar 5, 2019

@spacekookie Been thinking about this suggestion for a bit, at first I was "yes" but now leaning toward "no, but...".

My reasoning is: The emby project is not an open source project anymore. So an old version of emby won't fix issues/bugs/security problems of any kind in the open source version that they left behind. So I think the sensible thing would be to just mark it as an unfree license and then look for one of the emby forks (I think there should be at least one) and package that up as well. That gives people that use the open source emby a path to upgrade.

@etu
Copy link
Contributor

etu commented Apr 24, 2019

@spacekookie I just noticed that we have jellyfin as a package, which seem to be one of the dominant forks of emby: https://github.com/jellyfin/jellyfin

And with that I absolutely see no need to save an old version of emby.

But yeah, the license situation remains the issue with this PR.

@alyssais
Copy link
Member

If there's an actively maintained free fork, is there any reason for us to keep Emby around at all? I'd be curious to see what happened if we removed it (maybe replaced with throw saying to see if Jellyfin was appropriate) and seeing if anyone complained.

@etu etu closed this in #60630 May 3, 2019
@r-ryantm r-ryantm deleted the auto-update/emby branch May 11, 2019 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants