Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cryptominisat: 5.0.1 -> 5.6.6 #53398

Merged
merged 2 commits into from Jan 5, 2019
Merged

cryptominisat: 5.0.1 -> 5.6.6 #53398

merged 2 commits into from Jan 5, 2019

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Jan 4, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member Author

Mic92 commented Jan 4, 2019

@GrahamcOfBorg build cryptominisat

@xeji
Copy link
Contributor

xeji commented Jan 4, 2019

Doesn't build the full executable:

c NOTE: this is a SIMPLIFIED executable. For the full experience, you need to compile/obtain/use the 'cryptominisat5' executable. To compile that, you need the boost libraries. Please read the README.

Is this intended?

@Mic92
Copy link
Member Author

Mic92 commented Jan 5, 2019

I mainly used the library. Now it builds with boost.

@xeji
Copy link
Contributor

xeji commented Jan 5, 2019

Did the darwin build already fail before you added boost?

@Mic92
Copy link
Member Author

Mic92 commented Jan 5, 2019

I don't remember. Looking at the error most likely.

@Mic92
Copy link
Member Author

Mic92 commented Jan 5, 2019

@GrahamcOfBorg build cryptominisat

Without a macOS vm this is hard to debug. I could remove python from buildInputs though on macOS.

@xeji
Copy link
Contributor

xeji commented Jan 5, 2019

looks fine now.

@xeji xeji merged commit 361d64d into NixOS:master Jan 5, 2019
@Mic92 Mic92 deleted the cryptominisat branch January 5, 2019 16:50
@Mic92
Copy link
Member Author

Mic92 commented Jan 5, 2019

@GrahamcOfBorg build cryptominisat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants