Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cbor: init at 1.0.0 #53402

Merged
merged 1 commit into from Jan 4, 2019
Merged

cbor: init at 1.0.0 #53402

merged 1 commit into from Jan 4, 2019

Conversation

oxzi
Copy link
Member

@oxzi oxzi commented Jan 4, 2019

Motivation for this change

Introduces the cbor library for Python.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@oxzi oxzi requested a review from FRidh as a code owner January 4, 2019 12:55
@Ma27
Copy link
Member

Ma27 commented Jan 4, 2019

The derivation has an enabled check phase, but doesn't execute any tests which happens most likely because the PyPI tarball has its tests excluded. Can you please check if you manage to get the tests running in the build (and switch to the git source) or disable the checkPhase using doCheck = false; and leave a comment why :)

@oxzi
Copy link
Member Author

oxzi commented Jan 4, 2019

@Ma27: Thanks for your fast response! I've updated the PR and disabled the tests. After switching to the upstream source I realized that four unit tests are broken, which was already reported.

@Ma27
Copy link
Member

Ma27 commented Jan 4, 2019

built locally and tested basic functionality in a Python 2 and 3 environment 👍

@Ma27 Ma27 merged commit da4c730 into NixOS:master Jan 4, 2019
@Ma27
Copy link
Member

Ma27 commented Jan 4, 2019

@geistesk thanks!

@oxzi oxzi deleted the py-cbor-init branch March 10, 2019 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oxzi @Ma27 @GrahamcOfBorg