apache-httpd/wordpress: copy plugins and themes instead of symlinking #53399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basvandijk
suggested changes
Jan 6, 2019
…inking Symlinking works for most plugins and themes, but Avada, for instance, fails to understand the symlink, causing its file path stripping to fail. This results in requests that look like: https://example.com/wp-content//nix/store/...plugin/path/some-file.js Since hard linking directories is not allowed, copying is the next best thing.
FPtje
force-pushed
the
feat-wordpress-copy-plugins
branch
from
97bc39e
to
9d2c915
Compare
basvandijk
approved these changes
Jan 7, 2019
|
Another option could be patching the plugin :) |
|
I've considered that, but we've had this with two out of the twenty plugins now. We could go in hard headed here, but I'm afraid there will be many, many plugins that will need to be patched to account for symlinks. Besides, all the installation instructions about (manually) installing plugins say the files need to be placed in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Symlinking works for most plugins and themes, but Avada, for instance, fails to
understand the symlink, causing its file path stripping to fail. This results in
requests that look like:
https://example.com/wp-content//nix/store/...plugin/path/some-file.js
Since hard linking directories is not allowed, copying is the next best thing.
CC @basvandijk
Things done
Tested on our own webserver.
Tested using sandboxing (nix.useSandbox on NixOS, or option
sandboxinnix.confon non-NixOS)Built on platform(s)
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using
nix-shell -p nox --run "nox-review wip"Tested execution of all binary files (usually in
./result/bin/)Determined the impact on package closure size (by running
nix path-info -Sbefore and after)It will increase a bit because of the copying, but plugins aren't generally that big.
Assured whether relevant documentation is up to date
Fits CONTRIBUTING.md.