Player file directory must be only created when using file backend.

nerzhul · nerzhul · commit 07177190734b · 2019-01-04T10:06:46.000+01:00
Also ensure on each player save that the directory exists
diff --git a/src/database/database-files.cpp b/src/database/database-files.cpp
@@ -31,6 +31,11 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 // This backend is intended to be used on Minetest 0.4.16 only for the transition backend
 // for player files
 
+PlayerDatabaseFiles::PlayerDatabaseFiles(const std::string &savedir) : m_savedir(savedir)
+{
+	fs::CreateDir(m_savedir);
+}
+
 void PlayerDatabaseFiles::serialize(std::ostringstream &os, RemotePlayer *player)
 {
 	// Utilize a Settings object for storing values
@@ -58,6 +63,8 @@ void PlayerDatabaseFiles::serialize(std::ostringstream &os, RemotePlayer *player
 
 void PlayerDatabaseFiles::savePlayer(RemotePlayer *player)
 {
+	fs::CreateDir(m_savedir);
+
 	std::string savedir = m_savedir + DIR_DELIM;
 	std::string path = savedir + player->getName();
 	bool path_found = false;
diff --git a/src/database/database-files.h b/src/database/database-files.h
@@ -29,7 +29,7 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 class PlayerDatabaseFiles : public PlayerDatabase
 {
 public:
-	PlayerDatabaseFiles(const std::string &savedir) : m_savedir(savedir) {}
+	PlayerDatabaseFiles(const std::string &savedir);
 	virtual ~PlayerDatabaseFiles() = default;
 
 	void savePlayer(RemotePlayer *player);
diff --git a/src/serverenvironment.cpp b/src/serverenvironment.cpp
@@ -544,9 +544,6 @@ void ServerEnvironment::kickAllPlayers(AccessDeniedCode reason,
 
 void ServerEnvironment::saveLoadedPlayers()
 {
-	std::string players_path = m_path_world + DIR_DELIM + "players";
-	fs::CreateDir(players_path);
-
 	for (RemotePlayer *player : m_players) {
 		if (player->checkModified() || (player->getPlayerSAO() &&
 				player->getPlayerSAO()->getMeta().isModified())) {

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ with this program; if not, write to the Free Software Foundation, Inc.,`
`29`	`29`	`class PlayerDatabaseFiles : public PlayerDatabase`
`30`	`30`	`{`
`31`	`31`	`public:`
`32`		`- PlayerDatabaseFiles(const std::string &savedir) : m_savedir(savedir) {}`
	`32`	`+ PlayerDatabaseFiles(const std::string &savedir);`
`33`	`33`	`virtual ~PlayerDatabaseFiles() = default;`
`34`	`34`
`35`	`35`	`void savePlayer(RemotePlayer *player);`
Original file line number	Diff line number	Diff line change
`@@ -544,9 +544,6 @@ void ServerEnvironment::kickAllPlayers(AccessDeniedCode reason,`
`544`	`544`
`545`	`545`	`void ServerEnvironment::saveLoadedPlayers()`
`546`	`546`	`{`
`547`		`- std::string players_path = m_path_world + DIR_DELIM + "players";`
`548`		`- fs::CreateDir(players_path);`
`549`		`-`
`550`	`547`	`for (RemotePlayer *player : m_players) {`
`551`	`548`	`if (player->checkModified() \|\| (player->getPlayerSAO() &&`
`552`	`549`	`player->getPlayerSAO()->getMeta().isModified())) {`