Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minuet: Fix build #53391

Closed
wants to merge 2 commits into from
Closed

minuet: Fix build #53391

wants to merge 2 commits into from

Conversation

HaoZeke
Copy link
Member

@HaoZeke HaoZeke commented Jan 4, 2019 •
edited

Motivation for this change

Fixes #53340.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@HaoZeke HaoZeke requested a review from ttuegel as a code owner January 4, 2019 08:58
@Mic92
Copy link
Member

Mic92 commented Jan 4, 2019 •
edited

@schmittlauch we have the same problem with /bin/qmlcachegen here coming from a broken cmake file. This is the build error:
https://gist.github.com/d20df372666433095916a6e876b4ec60

@schmittlauch
Copy link
Member

@Mic92 This is my fix that makes ktouch build (although I have run-time issues afterwards): 7e9334f

@HaoZeke
Copy link
Member Author

HaoZeke commented Jan 4, 2019

This is currently failing only until #53380 is merged where I have added myself to the maintainers.

@schmittlauch
Copy link
Member

@HaoZeke At least given the build error described by Mic92, I cannot really see how #53380 fixes the qmlcachegen build error.

@HaoZeke
Copy link
Member Author

HaoZeke commented Jan 5, 2019 •
edited

@schmittlauch it doesn't, except that currently the automatic tests for this pr are failing because I added myself to maintainers.nix in the other PR.

Fixing this build error is done in 5ab9f63.
The automated tests for this PR are failing because of 3f2e5f7.

The check fails because:

undefined variable 'HaoZeke' at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/eval-0-gleber.ewr1.nix.ci/pkgs/applications/kde/minuet.nix:12:49

After the other PR is merged that would not be an undefined variable anymore.

@billksun billksun mentioned this pull request Jan 16, 2019
Merged
10 tasks
@billksun
Copy link
Contributor

@HaoZeke , is this ready now?

@Mic92
Copy link
Member

Mic92 commented Jan 18, 2019

@GrahamcOfBorg eval

@Mic92
Copy link
Member

Mic92 commented Jan 18, 2019

@GrahamcOfBorg build minuet

@schmittlauch
Copy link
Member

If the build still fails due to qmlcachegen: The fix for that is now in staging.

@Mic92
Copy link
Member

Mic92 commented Jan 18, 2019

Ok. Either this pr needs to go to staging to or we wait until staging is merged again.

@billksun billksun mentioned this pull request Jan 26, 2019
Closed
@HaoZeke HaoZeke mentioned this pull request Feb 10, 2019
Merged
@HaoZeke
Copy link
Member Author

HaoZeke commented Feb 10, 2019

Moved to staging @Mic92

@HaoZeke HaoZeke closed this Feb 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel Awaiting requested review from ttuegel

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

Assignees
No one assigned
Labels
6.topic: qt/kde 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@HaoZeke @Mic92 @schmittlauch @billksun @GrahamcOfBorg